forge-std icon indicating copy to clipboard operation
forge-std copied to clipboard

Different mumbai aliases

Open klkvr opened this issue 2 years ago • 1 comments

Right now, the most convinient way to name chains in config is by following naming used in Chains enum in ethers-rs (as discussed is https://github.com/foundry-rs/foundry/issues/4895). For mumbai network this alias is mumbai (polygon-mumbai is also fine, but mumbai seems to be the preferred one) https://github.com/gakonst/ethers-rs/blob/3e7606d81b423593db5a38dcf3b5174987efc74c/ethers-core/src/types/chain.rs#L99-L101

But following such pattern for this network results in it being non-found by StdChains, because it uses polygon_mumbai alias: https://github.com/foundry-rs/forge-std/blob/f18e8aa3e72eef83518766eb34ad8c8d8e2aa0aa/src/StdChains.sol#L204-L206

I think that it will make sense to change alias in initializeStdChains to mumbai and fix all such differences

klkvr avatar Aug 07 '23 02:08 klkvr

polygon_mumbai has been present for a long time, so this would be a breaking change that I'd like to avoid. Perhaps there's a way to cleanly support aliases though

mds1 avatar Aug 07 '23 20:08 mds1