inky icon indicating copy to clipboard operation
inky copied to clipboard

Change cheerio version to stable

Open lisunovdv opened this issue 4 years ago • 1 comments

cheerio v0.20.0 or v1.0.0-rc.5 parses incorectly custom self-closing XML tags, e.g:

<isinclude template="checkout/confirmation/confirmationEmail"/>

will become

<isinclude template="checkout/confirmation/confirmationEmail"/></isinclude>

And cheerio option recognizeSelfClosing: false can't help.

It's fixed only in the stable release of "cheerio" - v0.22.0 (that is used in inline-css

But v1.0.0-rc.5 has alatest tag so we need to write "cheerio": "0.22.0"' instead of "cheerio": "^0.22.0"`

lisunovdv avatar Jan 13 '21 21:01 lisunovdv

Hi @lisunovdv,

thanks for your PR.

But v1.0.0-rc.5 has alatest tag so we need to write "cheerio": "0.22.0"' instead of "cheerio": "^0.22.0"`

This is not correct. The SemVer range "^0.22.0" uses only 0.22.x, see:

Bildschirmfoto 2021-01-24 um 14 50 48 Bildschirmfoto 2021-01-24 um 14 53 35

We should not pin the version to get security updates.

DanielRuf avatar Jan 24 '21 13:01 DanielRuf