foundation-sites icon indicating copy to clipboard operation
foundation-sites copied to clipboard

Published 20 hours ago • verified publisher icon foundation

$header-styles forces REM - not possible to use EM, PX, ...

Open thomasfrobieter opened this issue 2 years ago • 0 comments

Maybe not an issue, but probably a thing to be discussed.

No matter if you set $header-margin-bottom: 0.5em; or $header-margin-bottom: 15px; or $header-margin-bottom: 0.5rem;

https://github.com/foundation/foundation-sites/blob/8846fdad0289d1a0a80929c92a4245fcb781c662/scss/typography/_base.scss#L330

will convert it to REM.

Why is this? From my point of view: I want to have the control over the unit. It's totally fine for me to set $header-margin-bottom: 0.5rem !default; but taking me out of control by converting each other format isn't that great..

thomasfrobieter avatar Feb 25 '22 10:02 thomasfrobieter