foundation-rails icon indicating copy to clipboard operation
foundation-rails copied to clipboard

Change SassC dependency to Dart Sass

Open ayaman opened this issue 1 year ago • 6 comments

Since SassC no longer supports the newer syntax used in foundation 6.8+, this pull request changes the dependency to Dart Sass.

ayaman avatar Oct 03 '24 21:10 ayaman

I'm not familiar with the dartsass libraries, but it looks like sass-embedded and sassc-embedded are actively maintained and the library chosen by dartsass-rails, while dartsass was last updated 2 years ago.

tlbraams avatar Oct 04 '24 09:10 tlbraams

You're quite right. I use dartsass-rails so I mistakenly assumed that they use dartsass. It seems sassc-embedded is the recommended option to go for. I'll adjust the pull request.

ayaman avatar Oct 04 '24 11:10 ayaman

I just went through the transition from sassc to dartsass-rails and it installs sass-embedded (not sassc-embedded) as its dependency, just thought I'd mention this. Also visible here: https://rubygems.org/gems/dartsass-rails/versions/0.5.1

arta avatar Nov 05 '24 21:11 arta

I'm going through the same migration but I've decided to replace the gem with a foundation-sites NPM install since the package is updated and it has no dependencies. I'm not sure if it would be possible for the gem without a major release but ideally it should not have sass, sassc, sass*-embedded or sprockets-es6 as dependencies. The latter is unnecessary and the former would be best to let the host app decide. Note that the foundation-sites does not specify a sass or babel dependency as an example.

javierjulio avatar Nov 07 '24 01:11 javierjulio

Any update on this?

prpetten avatar Apr 01 '25 01:04 prpetten

This PR is not needed anymore since adding to Gemfile:

gem 'dartsass-sprockets'
gem 'sass-embedded'

solves the problem. sassc-embedded provides a shim that satisfies foundation's dependency requirement about sassc. And it works flawlessly.

januszm avatar May 20 '25 23:05 januszm