foundation-emails icon indicating copy to clipboard operation
foundation-emails copied to clipboard

Published 20 hours ago • verified publisher icon foundation

  become  

Open afterbit01 opened this issue 7 years ago • 9 comments

Hi, when i use the inliner the entity " " become " " is it right?

afterbit01 avatar Oct 30 '17 11:10 afterbit01

I have the same issue with the inliner. Seems like a conversion bug between the HTML name and HTML number of a non-breaking space character. &nbps; vs.  

bartdevuyst avatar Nov 09 '17 14:11 bartdevuyst

https://foundation.zurb.com/emails/inliner-v2.html Same here

sollemar avatar Nov 27 '17 18:11 sollemar

Same as #763

julkue avatar Apr 23 '18 12:04 julkue

Bildschirmfoto 2020-01-31 um 01 32 32

DanielRuf avatar Jan 31 '20 00:01 DanielRuf

Not yet sure where exactly this is happening:

https://github.com/foundation/foundation-web-inliner/blob/master/lib/inline.js

DanielRuf avatar Jan 31 '20 00:01 DanielRuf

Seems it does not happen with the current status of the foundation-web-inliner project (chore/upgrade-browserify-html-minifier):

Bildschirmfoto 2020-01-31 um 01 45 41

https://github.com/foundation/foundation-web-inliner/pull/3

So this should be fixed with the next deployment.

DanielRuf avatar Jan 31 '20 00:01 DanielRuf

Old minifier from https://raw.githubusercontent.com/foundation/foundation-marketing/master/src/assets/lib/inliner.min.js

Bildschirmfoto 2020-01-31 um 01 54 18

DanielRuf avatar Jan 31 '20 00:01 DanielRuf

I guess the html markup comes from cheerio

https://github.com/cheeriojs/cheerio/search?q=xhtml+is%3Aissue&type=Issues

DanielRuf avatar Jan 31 '20 01:01 DanielRuf

This still seems to be an issue with the web-based inliner "copy to clipboard" button - & gets changed to & by that button. Am wondering when the fix will be released - the last discussion was about a year ago.

Thanks.

ghost avatar Feb 11 '21 18:02 ghost