foundation-emails icon indicating copy to clipboard operation
foundation-emails copied to clipboard

min-width: none is an invalid rule

Open keithort opened this issue 7 years ago • 4 comments

The none value on the min-width on https://github.com/zurb/foundation-emails/blob/develop/scss/grid/_grid.scss#L78 is invalid. none is valid for the max-width but not min-width. See https://developer.mozilla.org/en-US/docs/Web/CSS/min-width. This invalid property breaks the expected display in Chrome. Firefox modifies the value to initial and displays properly.

How can we reproduce this bug?

<container>
  <wrapper class="header">
    <container>
      <row>
        <columns small="12" large="3">
          <center>
           Test
          </center>
        </columns>
        <columns small="12" large="9" valign="middle">
          Lorem ipsum
        </columns>
      </row>
    </container>
  </wrapper>
</container>

What did you expect to happen? The tables wrapped in a <center> block should not have a minimum width.

What happened instead? The tables default to a fixed px based minimum width

What email clients does this happen in? All web clients when using Chrome.

keithort avatar Jul 03 '17 18:07 keithort

I'm seeing the same behaviour in Firefox 54.0.1 but it is not being automatically fixed.

veganista avatar Jul 20 '17 16:07 veganista

I'm having issues with this too in Firefox 57.

As I understand it, the intention of min-width: none is min-width: 0, since that's the smallest possible min-width you can have (negative values are invalid), and that's also the initial value. Hopefully email clients behave well with min-width: 0, although I haven't thoroughly tested it.

contivero avatar Dec 15 '17 13:12 contivero

There is a pending and approved PR fixing this issue. I don't understand why is taking so much time to complete the merge. It is an easy fix. It is just a matter checking how it works in email clients min-width: 0. Well, I've tested with litmus in a myriad of email clients and works fine.

It's possible there's no rush because is true than after executing the "inliner" process the inherited min-width issue is not present but... c'mon guys! you already have it fixed.

emoriarty avatar Apr 23 '19 10:04 emoriarty

@emoriarty please see https://github.com/zurb/foundation-emails/issues/944#issuecomment-467881737 for a possible explanation. As far as I understand, this project is still claimed to be maintained, however at the moment there is no one available who is permitted to actually commit, merge or release anything.

If the licence permits, by now I believe it most likely would be the most productive solution to get a few people together who are willing to work on this project and sort out PRs which are good enough and release a fork. Unfortunately, at the moment I can't find enough time to get all this started. And well, another option would be to ditch foundations and invest that time to help one of the other frameworks, that surely would be happy as well.

st-h avatar Apr 23 '19 14:04 st-h