foundation-emails icon indicating copy to clipboard operation
foundation-emails copied to clipboard

Docs say you can use $global-gutter-small in 2.2.0 but you can't

Open ItamarGronich opened this issue 5 years ago • 5 comments

Problem

documentation on global variables: https://get.foundation/emails/docs/global.html#sass-variables

It shows that you can use $global-gutter-small but it's only in the develop branch and not yet in any release. Also, docs say the version is 2.2.0 but it's actualy 2.2.1.

ItamarGronich avatar Apr 22 '20 14:04 ItamarGronich

Hi @ItamarGronich,

Thanks for letting us know. The docs are currently built from the develop branch afaik.

We will improve this in the future and also do a new release then.

DanielRuf avatar Apr 22 '20 16:04 DanielRuf

Regarding the outdated version in the docs:

https://github.com/foundation/foundation-emails/blob/develop/docs/partials/component-list.html#L3

PRs are very welcome.

DanielRuf avatar Apr 22 '20 16:04 DanielRuf

I installed v2.3.1 via npm and I see that the sccs files are different from the files in the repository ... Definitely, the comma (in the small, .small selector) is missing from _typography.sccs

pikhtin avatar Jan 05 '21 10:01 pikhtin

solved the bug using github repo as node module: npm install git+https://github.com/foundation/foundation-emails.git#develop

pikhtin avatar Jan 05 '21 10:01 pikhtin

I installed v2.3.1 via npm and I see that the sccs files are different from the files in the repository ...

You have probably looked at the develop branch instead of the relevant tag. See https://github.com/foundation/foundation-emails/tree/v2.3.1

As you can see at https://github.com/foundation/foundation-emails/releases/tag/v2.3.1 there are currently 20 commits which are not in a release yet.

DanielRuf avatar Jan 05 '21 10:01 DanielRuf