foundation-emails-template icon indicating copy to clipboard operation
foundation-emails-template copied to clipboard

Published 20 hours ago • verified publisher icon foundation

Custom data

Open zebapy opened this issue 8 years ago • 7 comments

Adds custom data file by default

Closes https://github.com/zurb/foundation-emails/pull/493 as the documentation update isn't necessary if this is merged

develop was out of date with master so that is part of this as well. If that's not how this should be handled, let me know.

zebapy avatar Jul 08 '16 19:07 zebapy

Thanks for the example

thomaswelton avatar Aug 23 '16 14:08 thomaswelton

Thanks for the PR! There seems to be some extra files here. Can you rebase or branch of of develop to resubmit for merge?

rafibomb avatar Nov 14 '16 22:11 rafibomb

@rafibomb is that better?

zebapy avatar Nov 18 '16 15:11 zebapy

I am doing exactly the same thing for my project and planning to make a pull request. But I just gave it up after seeing this.

Just one comment. I think adding .gitkeep file inside data folder is good enough. data.yml is not necessary because the data files should be created by developer.

jimmyko avatar Mar 23 '17 17:03 jimmyko

This should be merged. At the moment the docs do not describe this. The data property is missing by default. cc @maximilianUE

DanielRuf avatar Dec 20 '17 19:12 DanielRuf

I think it is good to have the documentation in the file as it is in the project and always available as a reference. The docs are always changing and not bound to specific releases or may be too new in some cases (think about maintaining an old panini / foundation-emails-template project in the future).

DanielRuf avatar Dec 20 '17 19:12 DanielRuf

See https://github.com/zurb/foundation-emails/commit/fb3fbea46d0a47898df1cd18031a82293e59fff6

DanielRuf avatar Dec 20 '17 19:12 DanielRuf