Mike Fotinakis

Sounds good! I'm sure you've seen it but this doc seems to have the rules for how Opaque is used to construct the URL: https://golang.org/pkg/net/url/#URL.String

So, maybe the bug here is that you're setting the opaque to RequestURI, which includes the scheme also, so the scheme gets double-included by URL.String(). Not sure if that's the...

Not an official one, I think it just needs a tiny bit of work to avoid setting `outReq.URL.Opaque` in some cases. Here's my current workaround, same as @dereulenspiegel above: https://github.com/percy/jackproxy/blob/e67c36b1ca97bc3f32f3e16d3b928eb17c8c97bc/roundtripper.go#L43

I believe this might be closed or obsoleted by https://github.com/vulcand/oxy/pull/108/files

jsonapi-serializers is not coupled at all to ActiveRecord at the moment, so no, not if we wanted to maintain that. We could potentially use those methods and have a fallback...

Yup that could work. I also like the more lightweight solution of just duck-type checking if the methods exist and then falling back, since there's not a lot of other...

Hmm, that's _not_ intentional. In a pre-1.0 version of the spec, the spec said to only include leaf nodes for includes, but in the 1.0 spec they changed it to...

Interesting...I looked through the code again too and I think you are probably right. I just pushed https://github.com/fotinakis/jsonapi-serializers/commit/63e1132b67124469395cdde38a9a29c4e037eb52 to a branch named `test-string-symbol-bug` — can you test with this branch...

Actually, it's probably something else, the line you referenced: `if @_include_linkages.include?(formatted_attribute_name)` compares a string, in `@_include_linkages`, to a string in `formatted_attribute_name` (the `format_name` method does `.to_s` inside it). Probably back...

Have you implemented a custom `format_name` method by chance?