atarashi icon indicating copy to clipboard operation
atarashi copied to clipboard

Pipfile: the replacement for requirements.txt

Open Kaushl2208 opened this issue 4 years ago • 9 comments

We can migrate our current requirement.txt file to pipfile due to several reasons like:

  • TOML syntax for declaring all types of Python dependencies.
  • One Pipfile (as opposed to multiple requirements.txt files).
  • A Pipfile is inherently ordered.

or, Refer: Why?

Kaushl2208 avatar Mar 11 '20 10:03 Kaushl2208

That would be a good change. But will it effect the existing pyproject.toml (compatibility with PEP 518)?

GMishx avatar Mar 12 '20 06:03 GMishx

Yes, It will replace pyproject.toml and it might affect setup.py. Not sure, about it rn.

Can I submit a PR for it?

Kaushl2208 avatar Mar 12 '20 10:03 Kaushl2208

Yes, sure @Kaushl2208. Just make sure the current build wheel build should not break because of this change.

GMishx avatar Mar 13 '20 10:03 GMishx

Is this still open @GMishx ? I wanna work on this.

lohithmunakala avatar Sep 22 '20 03:09 lohithmunakala

Yes @lohithmunakala, from my end the issue is still open. @Kaushl2208 do let us know if you are working on the issue.

It will be nice to assign the issue to the person currently working on it.

GMishx avatar Sep 22 '20 04:09 GMishx

If @Kaushl2208 isn't working on it rn, can you help me get started with the issue @GMishx ?

lohithmunakala avatar Sep 22 '20 07:09 lohithmunakala

Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.

Kaushl2208 avatar Sep 22 '20 08:09 Kaushl2208

Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.

Meanwhile @lohithmunakala You can start working on this issue. It will be a great help.

hastagAB avatar Sep 22 '20 08:09 hastagAB

I have assigned the ticket to you @lohithmunakala .

You can start looking into pipenv documentation: https://pipenv.pypa.io/en/stable/ Expectation from this change is:

  1. Removal of dependencies from requirements.txt and setup.py
  2. Should not break PEP 517 changes (try to build Dockerfile to test)
  3. Clear separation of additional dependencies like csv and json files generated by running python3 setup.py build

GMishx avatar Sep 22 '20 09:09 GMishx