atarashi
atarashi copied to clipboard
Pipfile: the replacement for requirements.txt
We can migrate our current requirement.txt file to pipfile due to several reasons like:
- TOML syntax for declaring all types of Python dependencies.
- One Pipfile (as opposed to multiple requirements.txt files).
- A Pipfile is inherently ordered.
or, Refer: Why?
That would be a good change. But will it effect the existing pyproject.toml (compatibility with PEP 518)?
Yes, It will replace pyproject.toml and it might affect setup.py. Not sure, about it rn.
Can I submit a PR for it?
Yes, sure @Kaushl2208. Just make sure the current build wheel build should not break because of this change.
Is this still open @GMishx ? I wanna work on this.
Yes @lohithmunakala, from my end the issue is still open. @Kaushl2208 do let us know if you are working on the issue.
It will be nice to assign the issue to the person currently working on it.
If @Kaushl2208 isn't working on it rn, can you help me get started with the issue @GMishx ?
Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.
Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.
Meanwhile @lohithmunakala You can start working on this issue. It will be a great help.
I have assigned the ticket to you @lohithmunakala .
You can start looking into pipenv documentation: https://pipenv.pypa.io/en/stable/ Expectation from this change is:
- Removal of dependencies from requirements.txt and setup.py
- Should not break PEP 517 changes (try to build Dockerfile to test)
- Clear separation of additional dependencies like
csv
andjson
files generated by runningpython3 setup.py build