FOSSologyUI icon indicating copy to clipboard operation
FOSSologyUI copied to clipboard

Published 20 hours ago • verified publisher icon fossology

feat(UI): Upload permissions page UI and API Implementation done

Open krishna9304 opened this issue 2 years ago • 8 comments

Description

Ui and API Implementation of the Upload Permissions page.

Tasks Done

  • [x] Create the static UI.
  • [x] Implement data retrieval from html forms.
  • [x] Implement the new API in PR #2275.
  • [x] Test everything.

Demo Screenshots

https://user-images.githubusercontent.com/71918441/184526229-9f333dc6-d573-4b57-9171-80d1bfe30163.mp4

How to test

  • Install the API from -> #2275 in the fossology backend.
  • In the UI Go to admin>Upload Permissions
  • The route is available at /admin/upload-permissions

cc: @Shruti3004 @GMishx This closes #247 .

krishna9304 avatar Aug 14 '22 07:08 krishna9304

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 25 '22 11:08 github-actions[bot]

@krishna9304 : UI looks good. except that I'm facing issue with adding user to upload who is not first. Page reload every time is causing this can you please check ?

shaheemazmalmmd avatar Aug 25 '22 12:08 shaheemazmalmmd

@krishna9304 : UI looks good. except that I'm facing issue with adding user to upload who is not first. Page reload every time is causing this can you please check ?

yes, there are some changes in the backend that's causing this issue. I'll fix this and update the PR.

krishna9304 avatar Aug 26 '22 09:08 krishna9304

Fixed the issues and updated the PR. PTAL @shaheemazmalmmd .

krishna9304 avatar Aug 29 '22 13:08 krishna9304

resolved conflicts @shaheemazmalmmd .

krishna9304 avatar Aug 30 '22 06:08 krishna9304

@krishna9304 While testing i have found that i was not able to render the groups also the public permissions has been changed to user permission. please not that public permissions here are specific to upload not to user.

shaheemazmalmmd avatar Aug 30 '22 11:08 shaheemazmalmmd

@krishna9304 While testing i have found that i was not able to render the groups also the public permissions has been changed to user permission. please not that public permissions here are specific to upload not to user.

Update the PR. PTAL at the recent changes. @shaheemazmalmmd

krishna9304 avatar Sep 01 '22 08:09 krishna9304

@krishna9304 I have tested the Pull request and i still see the same issue.

shaheemazmalmmd avatar Sep 05 '22 10:09 shaheemazmalmmd