aura icon indicating copy to clipboard operation
aura copied to clipboard

Aura not copying install scripts to build directory

Open emekoi opened this issue 7 months ago • 2 comments

The package notion-app-electron has a install script named .install, however the build directory is missing this file even though it is in the cloned Git repo which causes the build to fail almost instantly:

~ 
❯ ls -a ~/.cache/aura/builds/notion-app-electron/
./  ../  notion-app*  notion.desktop  notion.png  PKGBUILD

~ 
❯ ls -a ~/.cache/aura/packages/notion-app-electron/
./  ../  .git/  .gitignore  .install  notion-app*  notion.desktop  notion.png  PKGBUILD  .SRCINFO

I believe the issue is in build::all_install_files. It uses PathBuf::extension and from the docs, that returns None if the file starts with a leading . and has no other .s. There probably needs to be some other custom logic for detecting install files or we could hardcode the check for files named .install. notion-app-electron isn't the only package I've had issue installing because of this, but it is the most recent one.

emekoi avatar May 18 '25 04:05 emekoi

Actually, since these files are mentioned in the PKGBUILD, maybe it would be easiest to just combine explicitly specified install files with any other files all_install_files finds? If that sounds good, I could try writing up a PR for that.

emekoi avatar May 18 '25 05:05 emekoi

Thanks for the report, I'll look into this.

fosskers avatar May 20 '25 08:05 fosskers