Use vcs folder for non -git,svn etc. packages from aur if they use git to download sources.

[micwoj92]

There are some non vcs packages which use git to download, every time there is update(or delete package and rebuild), it redownloads whole repo and takes much more network and disk usage. So I mean that aura should detect download agent used and place in vcs folder based on that.

Example packages from aur: gtk-frdp, palemoon

[ratijas]

Are you referring to these lines in prepare() step?

prepare() {
  sed 's#%SRCDIR%#'"${srcdir}"'#g' mozconfig.in > mozconfig
  cd ${_repo}
  git submodule init
  git config submodule.platform.url "${srcdir}/UXP"
  git submodule update
}

I wonder, if that's even a good practice. If they are "non vcs", then why using git in the first place?

[micwoj92]

No, im not referring to these lines. Just that in build directory, every aura -Ax packagename will do this:

For vcs packages it's just one folder for a package: example

I wonder, if that's even a good practice.

That is official build instructions. I have no idea if that is good build practice.

If they are "non vcs", then why using git in the first place?

Even official arch packages use that, example is many gnome packages. It just downloads much less data in long run. example, gnome-autoar https://github.com/archlinux/svntogit-packages/blob/packages/gnome-autoar/trunk/PKGBUILD#L14

[fosskers]

Official packages can be built/named however the Arch guys please. Were gnome-autoar an AUR package I would call that a packaging mistake.

Looking at palemoon that's the judgment I'll have to make too, that the package is named incorrectly. The question is whether or not we want to "forgive" this and try and detect git lines in the sources array manually. My instinct says no, to stay away from error-prone Bash scanning. That said, the PKGBUILDs are already parsed once to detect security issues, so I'm split at the moment.