Aura cannot build `ltunify-git`

[ultimatespirit]

Aura can no longer build ltunify-git (https://aur.archlinux.org/packages/ltunify-git), though I'm not sure since when this broke given that I installed this back in the haskell version of aura.

Attempting to upgrade ltunify-git results in the following:

$ aura -Aka ltunify-git
aura :: Determining dependencies...
aura :: AUR packages:
 ltunify-git
aura :: Proceed? [Y/n] 
aura :: Preparing build directories...
aura :: Building ltunify-git...
==> ERROR: changelog file (NEWS) does not exist or is not a regular file.
aura :: Package failed to build, citing:

  makepkg failed.

aura :: Action cancelled.

Further diagnostic detail:

$ ls -a packages/ltunify-git/
.  ..  .git  NEWS  PKGBUILD  .SRCINFO
$ ls -a builds/ltunify-git/
.  ..  PKGBUILD

and

$ cat builds/ltunify-git/PKGBUILD 
# Maintainer: Peter Wu <[email protected]>
# Contributor: Adrien Sohier <[email protected]>
pkgname=ltunify-git
pkgver=0.2.22.gc3a263f
pkgrel=2
pkgdesc="A command-line tool to pair Logitech Unifying devices"
arch=('i686' 'x86_64' 'ARM')
url="https://lekensteyn.nl"
license=('GPL')
depends=('glibc')
makedepends=('git')
source=('git+https://git.lekensteyn.nl/ltunify.git')
md5sums=('SKIP')
changelog='NEWS'
_gitname='ltunify'

pkgver() {
	cd "$_gitname"
	git describe --always | sed 's|^v||;s|-|.|g'
}

build() {
	cd "$_gitname"
	make ltunify
}

package() {
	cd "$_gitname"
	install -Dm755 ltunify "$pkgdir/usr/bin/ltunify"
	install -Dm644 udev/42-logitech-unify-permissions.rules \
		"$pkgdir/usr/lib/udev/rules.d/42-ltunify-permissions.rules"
}

I think the issue is that changelog depends upon NEWS, which is obtained via the git clone, however NEWS is not listed under source. Presumably aura parses source for figuring out what to copy to builds/... besides PKGBUILD, and so it misses NEWS, leading to the failure.

What I'm not sure about here is if this is a logical error on aura's part or a technical fault of the PKGBUILD in question. Logically, specifying changelog should imply source, but I see nothing in the documentation actually saying that is the case. So then it presumably falls to source's documentation alone, which only specifies exclusions for .install files, which NEWS is not.

That being said, the fact that a missing changelog spec fails the build means it's functionally no different from having put that file in source. So I'd argue even if it may technically be ambiguous if files specified in changelog should be duplicated in source or not, aura should check for changelog in addition to source when copying files to builds/... directories.