pslab-android icon indicating copy to clipboard operation
pslab-android copied to clipboard

Oscilloscope: After selecting PSLab MIC, In-Built-MIC does not work when PSLab device is not connected

Open arpoch opened this issue 4 years ago • 2 comments

Actual Behaviour On selecting PSLab MIC option before the In-Built MIC option, no popup stating if a PSLab device is not connected, when selecting In-Build MIC no activity can be seen on the monitor.

Expected Behaviour The PSLab MIC option should be unable when then PSLab device is not connected.

Screenshots of the issue Screenshot_20210120-125534_PSLab

Would you like to work on the issue? Yes

arpoch avatar Jan 20 '21 07:01 arpoch

If have applied the changes, and the code is working fine. So should I now make a PR, can any please guide me through the procedure as it's my first PR.

Screenshot_20210122-225917_PSLab

arpoch avatar Jan 22 '21 17:01 arpoch

Good. Create a new branch and push the changes to that branch. Later make pull request to development branch .

asaikarthikeya avatar Jan 22 '21 18:01 asaikarthikeya

Superseeded by #2421 and resolved by #2422.

AsCress avatar May 26 '24 16:05 AsCress