pslab-android icon indicating copy to clipboard operation
pslab-android copied to clipboard

bug: Recording start even when device not connected

Open dheerajkotwani opened this issue 5 years ago • 7 comments

Actual Behaviour Recording can be started even if the device is not connected to mobile or mobile does not have inbuilt feature support

Expected Behaviour If any device is not connected then for that device recording should not start

Steps to reproduce it Open any device which is not connected or whose sensor are not present in mobile(Gas Sensor) Click on Record button See the error

Screenshots of the issue recording_issue

Would you like to work on the issue? Yes

dheerajkotwani avatar Jan 26 '20 05:01 dheerajkotwani

Expected behavior would be a pop up "Please connect a device or choose an phone sensor (if available)" and two buttons "Configure Active Sensor" and "Cancel".

mariobehling avatar Feb 03 '20 13:02 mariobehling

In sensors that are usually present on the phone the recording should work nevertheless.

mariobehling avatar Feb 03 '20 13:02 mariobehling

I am a beginner. I want to work on this issue please assign me

SpandanBasu avatar Jan 03 '21 12:01 SpandanBasu

When the sensor is not present and the user clicks on the recording button, A pop-up dialog comes..right..but on pressing on Configure active sensor where should the app take the user?

SpandanBasu avatar Jan 03 '21 14:01 SpandanBasu

Please assign this issue to me

sambhavsaxena avatar Jan 05 '21 14:01 sambhavsaxena

This issue is already fixed i opened a pull request. Try a different issue. Thanks

SpandanBasu avatar Jan 05 '21 16:01 SpandanBasu

Hey @mariobehling , Issue is fixed and PR is merged already so i think we can close this. Thank you.

shubham-200315 avatar Jan 07 '24 08:01 shubham-200315