Full testsuite for AYAB plugin

[tian2992]

Will require mocking and emulation of Serial Port

[shiluka]

Hi @tian2992, I am currently working on this issue by creating tests for ayab_image and ayab_communication. Can I work on this issue ?

[tian2992]

There are two main issues that make this full stack testing hard.

• Emulation of device The knitting process expects replies and continuous communication from the device. To fully emulate that we should develop a mock serial port object that allows for programmable message sending and message replies that is comparable to the behaviour of the real AYAB board. This would also mean doing that for every other device we would like to test.
• User facing Interactive behaviour. Interactive callbacks reduce this problem, however as callbacks do require actions to be taken on the user side (changing some setting, moving some dial, pushing a button, etc), those need to be emulated as well. https://github.com/fashiontec/knitlib/blob/master/src/knitlib/plugins/knitting_plugin.py#L50

If you only do tests for ayab_communication, bear in mind that this tests will only cover that code instead of being a full stack test. However learning from those tests can be useful and can help to make ayab_communication more generic.

I would also not recommend creating a test for ayab_image as it is up to a certain way, a way more primitive version of the holding object of what can be in the future a Knitpat object.

[shiluka]

ok thanks for the comment.

[tian2992]

Also please see #25 Cheers :)

[shiluka]

Thanks :)

[tian2992]

Except for full device emulation, I'd consider this mostly done.