flappy-svg icon indicating copy to clipboard operation
flappy-svg copied to clipboard

Published 20 hours ago • verified publisher icon fossasia

Changed the Sounds URL

Open Asher-MS opened this issue 3 years ago • 7 comments

Change the sound URL from "../flappy-svg/Sounds/Flappy.mp3" to "../Sounds/Flappy.mp3" and "../flappy-svg/Sounds/GameOver.mp3" to "../Sounds/GameOver.mp3"

Asher-MS avatar Aug 30 '21 11:08 Asher-MS

Can I see some testing please?

abishekvashok avatar Sep 06 '21 05:09 abishekvashok

Ok sure how should I show the testing??

Asher-MS avatar Sep 06 '21 06:09 Asher-MS

Show a screencast of it working? Providing a deployment link for anyone to go and test? There are plenty of ways :)

abishekvashok avatar Sep 06 '21 06:09 abishekvashok

video Link : https://drive.google.com/file/d/1K2ecU8zV9-gYdxPUY-23C4q6HNPvoGuH/view?usp=sharing

Asher-MS avatar Sep 06 '21 07:09 Asher-MS

Yep seems fine. I will checkout the code locally and get back.

abishekvashok avatar Sep 06 '21 07:09 abishekvashok

OK Sure✌

Asher-MS avatar Sep 06 '21 07:09 Asher-MS

Will it be merged?? @abishekvashok

Asher-MS avatar Sep 14 '21 15:09 Asher-MS