accounts.susi.ai icon indicating copy to clipboard operation
accounts.susi.ai copied to clipboard

Theme is not changing to "Dark"

Open akshitaagarwa11a opened this issue 6 years ago • 10 comments

Actual Behaviour

When the radio button for "Dark Theme" is selected, it doesn't change.

Expected Behaviour

The theme should change to a dark one

Steps to reproduce it

Go to settings/themes. Select the "Dark" theme. The theme won't change.

Screenshots of the issue

dark

Would you like to work on the issue?

Yes

akshitaagarwa11a avatar Sep 18 '18 04:09 akshitaagarwa11a

Does a dark theme even exist?

tabesin avatar Sep 19 '18 08:09 tabesin

There is a button for a dark theme and the theme should change like it does in chat.susi.ai.

akshitaagarwa11a avatar Sep 19 '18 10:09 akshitaagarwa11a

@akshi-11 @akshi-11 , changing the theme option in accounts, changes the theme in chat.susi.ai as of now.

sansyrox avatar Sep 23 '18 06:09 sansyrox

@stealthanthrax but should't the theme of accounts also change?

akshitaagarwa11a avatar Sep 23 '18 06:09 akshitaagarwa11a

@stealthanthrax I completely agree with you but there is a slight problem.... if I want to change the theme from chat settings, the theme doesn't change. You can give it a try by changing themes from both accounts.susi.ai and chats.susi.ai (the former one works, but not the latter)

singhrohan62 avatar Sep 23 '18 06:09 singhrohan62

One more thing, @akshi-11 its just a suggestion for you, disable (don't display) the 'edit theme' button when user opts for light or dark theme because the props for those themes are pre-defined and the button has no use for both those themes.

singhrohan62 avatar Sep 23 '18 06:09 singhrohan62

@singhrohan62 yes I will do that. But can u please explain why shouldn't the theme in accounts change?

akshitaagarwa11a avatar Sep 23 '18 06:09 akshitaagarwa11a

@akshi-11 my concern was regarding the problem which I have stated in my first comment. Btw, I am also in the favour of adding the dark theme in accounts.susi.ai 👍

singhrohan62 avatar Sep 23 '18 07:09 singhrohan62

@singhrohan62 thank you for the suggestion, I will work on the issue.

akshitaagarwa11a avatar Sep 23 '18 07:09 akshitaagarwa11a

@akshi-11 @singhrohan62 , a good solution would be to add a separate row(in the same tab) for the themes of the accounts and the web app. As themes tab in the accounts should also be able to toggle the web app themes,imo.

sansyrox avatar Sep 23 '18 15:09 sansyrox