Connect-Me icon indicating copy to clipboard operation
Connect-Me copied to clipboard

Published 20 hours ago • verified publisher icon fossasia

Adding an in-built Subscribe button

Open 0x48piraj opened this issue 7 years ago • 18 comments

Current State :

No such implementation yet.

Expected Outcome :

A Subscribe button to let users subscribe to FOSSASIA.

0x48piraj avatar Jan 18 '18 07:01 0x48piraj

@0x48piraj Can you please elaborate? By "subscribe to FOSSASIA" do you mean to subscribe to Fossasia's mail?

prshntsingh avatar Feb 04 '18 12:02 prshntsingh

Indeed. @prshntsingh 👍

0x48piraj avatar Feb 04 '18 18:02 0x48piraj

@0x48piraj Can I work on this issue?

prshntsingh avatar Feb 05 '18 07:02 prshntsingh

Absolutely. Start right away!

0x48piraj avatar Feb 05 '18 08:02 0x48piraj

Okay🙂

prshntsingh avatar Feb 05 '18 08:02 prshntsingh

Any Updates @prshntsingh ?

0x48piraj avatar Feb 28 '18 17:02 0x48piraj

@0x48piraj was busy with my institute exams.I will work on it this weekend.

prshntsingh avatar Feb 28 '18 17:02 prshntsingh

Updates @prshntsingh ?

0x48piraj avatar Apr 24 '18 13:04 0x48piraj

@0x48piraj sorry for late reply.Actually my institute exams are going on. I will do it as soon as it gets over.

prshntsingh avatar Apr 29 '18 23:04 prshntsingh

@0x48piraj @prshntsingh I would like to add subscribe button. Can I work on this?

Rishabh570 avatar May 20 '18 14:05 Rishabh570

Definitely! Go on!

0x48piraj avatar May 20 '18 15:05 0x48piraj

@0x48piraj Actually I've added the subscribe button and it's working completely fine for chrome but transitions in firefox are broken, I don't know why (I'm using Jquery's fadeIn() and hide())...

Screenshot for Chrome

main-layout

subscribe-form

Screenshot for firefox

buggy

Should I first fix it for firefox then open a PR or just open a PR so that other people could help in it??

Rishabh570 avatar May 23 '18 14:05 Rishabh570

Hey, I worked on this issue and opening a pull request. See to it.

mohitsharma23 avatar May 24 '18 22:05 mohitsharma23

@0x48piraj I have fixed this under the issue #33 . Suggest other changes.

NirmalKumarJoshi avatar Feb 18 '19 11:02 NirmalKumarJoshi

any work left on this issue?

HemabhKamboj avatar Feb 19 '19 18:02 HemabhKamboj

Link the Pull Request.

0x48piraj avatar Feb 25 '19 03:02 0x48piraj

I have fixed the issue. I will generate a PR on Mar 1.

NirmalKumarJoshi avatar Feb 25 '19 03:02 NirmalKumarJoshi

Hey I can build the subscribe button but I know the web scraping with puppeteer so should I commit the extension built on puppeteer or You can explain what u have used in this extension.

ShubhamChaudharyy avatar Oct 07 '19 11:10 ShubhamChaudharyy