2019.fossasia.org icon indicating copy to clipboard operation
2019.fossasia.org copied to clipboard

Published 20 hours ago • verified publisher icon fossasia

Update mobile view

Open pranavkarthik10 opened this issue 5 years ago • 6 comments

  • [x] Included a Preview link and screenshot showing after and before the changes.
  • [x] Included a description of the change below.
  • [x] Squashed the commits.

Changes done in this Pull Request

  • Fixes #118

Description / Changes

I updated the view using the overflow-x attribute for the body to hidden which allowed all overflow to be modified and changed to only fit the view.

Screenshots if any:

Before:

Screen Shot 2019-12-29 at 3 43 30 PM

After:

Screen Shot 2019-12-29 at 3 19 15 PM

pranavkarthik10 avatar Dec 29 '19 23:12 pranavkarthik10

@mariobehling Please review and merge! Thanks :)

pranavkarthik10 avatar Dec 31 '19 15:12 pranavkarthik10

@pranavkarthik10 pls have a look at the Schedule Roster section, hope it doesn't get affected / cut due to this. Thanks.

Dishebh avatar Jan 01 '20 07:01 Dishebh

@Dishebh Thank you for letting me know! I have fixed it and simplified the code massively by converting the schedule roster section to an image. It still preserves quality in different devices. Screen Shot 2020-01-01 at 8 44 36 PM

pranavkarthik10 avatar Jan 02 '20 04:01 pranavkarthik10

@mariobehling Please review this! Thank you.

pranavkarthik10 avatar Jan 02 '20 05:01 pranavkarthik10

@mariobehling Please review and merge when you get a chance. Thanks!

pranavkarthik10 avatar Jan 08 '20 06:01 pranavkarthik10

@mariobehling May I know why, otherwise the schedule roster section is the only reason why the mobile view does not look good. There are other ways to make it responsive but it would not look as good as the desktop version.

pranavkarthik10 avatar Jan 13 '20 01:01 pranavkarthik10