2018.fossasia.org icon indicating copy to clipboard operation
2018.fossasia.org copied to clipboard

(UI) Header Logo and Menu Alignment Issue

Open niranjannitesh opened this issue 6 years ago • 21 comments

screenshot from 2018-10-25 21-38-07 Would You Like to Work on it Yes

niranjannitesh avatar Oct 25 '18 16:10 niranjannitesh

Fixed Via #647

ArvindRP avatar Oct 18 '19 17:10 ArvindRP

i want to work on this .can you please allow me

Shyam-Sunder-saini avatar Oct 07 '20 16:10 Shyam-Sunder-saini

Can I work on this issue?

dineshssdn-867 avatar Dec 01 '20 13:12 dineshssdn-867

@Shyam-Sunder-saini @ssdn-867 Sorry! I have been quite inactive for a while and I was waiting for @ArvindRP PR to get merged I haven't checked it yet! but either one of your open to working on it now

niranjannitesh avatar Dec 01 '20 14:12 niranjannitesh

@niteshkumarniranjan Please check the PR made by me.

dineshssdn-867 avatar Dec 02 '20 16:12 dineshssdn-867

Waiting for reply @niteshkumarniranjan

dineshssdn-867 avatar Dec 05 '20 07:12 dineshssdn-867

@ssdn-867 Can you please link your PR here, also I am not a maintainer so I can't approve anything.

niranjannitesh avatar Dec 08 '20 12:12 niranjannitesh

Thank you for the reply @niteshkumarniranjan .Here is the P.R link in this P.R both header logo and color issue are solved.Link:https://github.com/fossasia/2018.fossasia.org/pull/652/commits/69ebbb312c79f72bda953571864b55f0aec0c490

dineshssdn-867 avatar Dec 11 '20 05:12 dineshssdn-867

Hello sir is this PR acceptable or there is a need or requirement of any change in the source code.

dineshssdn-867 avatar Dec 19 '20 18:12 dineshssdn-867

Hi @ssdn-867 Sorry but the link that you have provided doesn't link to a PR. Also, you don't need to call me sir.

niranjannitesh avatar Dec 20 '20 18:12 niranjannitesh

Thank you for the reply @niteshkumarniranjan and I am extremely sorry for the inconvenience caused to you. I completely understand that your time is precious. .Here is the P.R link in this P.R both header logo and color issue are solved. Link:#652. Again sorry for the inconvenience caused to you.

dineshssdn-867 avatar Dec 21 '20 04:12 dineshssdn-867

Can I work on this issue? It will be my first contribution

Priiyaa avatar May 06 '21 06:05 Priiyaa

@niteshkumarniranjan what the problem in header logo and menu alignment its seems fine to me as well as it is responsive too, I have made these implications based on what I saw on website https://2018.fossasia.org. but if you can suggest what are the problem I will be happy to contibute.

Vaibhav-afk avatar May 07 '21 17:05 Vaibhav-afk

@Vaibhav-afk

image

niranjannitesh avatar May 07 '21 18:05 niranjannitesh

Oh, I got you . Can you assign me?

Vaibhav-afk avatar May 07 '21 18:05 Vaibhav-afk

@Priiyaa and @ArvindRP sure go ahead, but I don't think that fossasia is managing this repo anymore. Also, it's been almost 3 years and I am just a contributor so, I can't merge your PRs or anything.

niranjannitesh avatar May 07 '21 18:05 niranjannitesh

@Vaibhav-afk I am just a contributor I can't assign anyone but you are free to work on it, at least from my side.

niranjannitesh avatar May 07 '21 18:05 niranjannitesh

Okay, no problem.

Vaibhav-afk avatar May 07 '21 18:05 Vaibhav-afk

can I work on this issue?

Soumyafc avatar May 09 '21 08:05 Soumyafc

thank you!

On Fri, May 7, 2021 at 11:42 PM Nitesh Kumar Niranjan < @.***> wrote:

@Priiyaa https://github.com/Priiyaa and @ArvindRP https://github.com/ArvindRP sure go ahead, but I don't think that fossasia is managing this repo anymore. Also, it's been almost 3 years and I am just a contributor so, I can't merge your PRs or anything.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/2018.fossasia.org/issues/640#issuecomment-834666443, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKZ54SGXH6MNKIHSXRYYN3TMQUSNANCNFSM4F7KP3NA .

Priiyaa avatar May 11 '21 15:05 Priiyaa

please allow me to fix this issue

madhav-goyal avatar Oct 09 '21 13:10 madhav-goyal