2018.fossasia.org
2018.fossasia.org copied to clipboard
(UI) Header Logo and Menu Alignment Issue
Would You Like to Work on it
Yes
Fixed Via #647
i want to work on this .can you please allow me
Can I work on this issue?
@Shyam-Sunder-saini @ssdn-867 Sorry! I have been quite inactive for a while and I was waiting for @ArvindRP PR to get merged I haven't checked it yet! but either one of your open to working on it now
@niteshkumarniranjan Please check the PR made by me.
Waiting for reply @niteshkumarniranjan
@ssdn-867 Can you please link your PR here, also I am not a maintainer so I can't approve anything.
Thank you for the reply @niteshkumarniranjan .Here is the P.R link in this P.R both header logo and color issue are solved.Link:https://github.com/fossasia/2018.fossasia.org/pull/652/commits/69ebbb312c79f72bda953571864b55f0aec0c490
Hello sir is this PR acceptable or there is a need or requirement of any change in the source code.
Hi @ssdn-867 Sorry but the link that you have provided doesn't link to a PR. Also, you don't need to call me sir.
Thank you for the reply @niteshkumarniranjan and I am extremely sorry for the inconvenience caused to you. I completely understand that your time is precious. .Here is the P.R link in this P.R both header logo and color issue are solved. Link:#652. Again sorry for the inconvenience caused to you.
Can I work on this issue? It will be my first contribution
@niteshkumarniranjan what the problem in header logo and menu alignment its seems fine to me as well as it is responsive too, I have made these implications based on what I saw on website https://2018.fossasia.org
. but if you can suggest what are the problem I will be happy to contibute.
@Vaibhav-afk
Oh, I got you . Can you assign me?
@Priiyaa and @ArvindRP sure go ahead, but I don't think that fossasia is managing this repo anymore. Also, it's been almost 3 years and I am just a contributor so, I can't merge your PRs or anything.
@Vaibhav-afk I am just a contributor I can't assign anyone but you are free to work on it, at least from my side.
Okay, no problem.
can I work on this issue?
thank you!
On Fri, May 7, 2021 at 11:42 PM Nitesh Kumar Niranjan < @.***> wrote:
@Priiyaa https://github.com/Priiyaa and @ArvindRP https://github.com/ArvindRP sure go ahead, but I don't think that fossasia is managing this repo anymore. Also, it's been almost 3 years and I am just a contributor so, I can't merge your PRs or anything.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/2018.fossasia.org/issues/640#issuecomment-834666443, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKZ54SGXH6MNKIHSXRYYN3TMQUSNANCNFSM4F7KP3NA .
please allow me to fix this issue