fossa-cli icon indicating copy to clipboard operation
fossa-cli copied to clipboard

`fossa analyze` has no option for "all-or-nothing" analysis.

Open jrudolph opened this issue 4 years ago • 5 comments

As observed in https://github.com/akka/akka-grpc/issues/1466, fossa might return a zero exit code even if analyzing a project has failed. In that case the reason might be that there are multiple build projects found and only some can be successfully analyzed. We need to make sure that the command reliably fails if any of the builds cannot be analyzed.

jrudolph avatar Oct 04 '21 13:10 jrudolph

Thanks for the input.

At the moment, this is as designed. Historically, our users prefer to upload SOMETHING, even if some of the builds fail. This is because most users don't want us to stop their CI from completing, even if their licensing isn't up to date

Theoretically, we could add an option to either report on any failure or upload on 0 failures. I will internally ticket this, and we will update this ticket with any new info.

I will also note that this does not affect fossa test. fossa analyze is solely responsible for this, though it would affect the results of fossa test.

skilly-lily avatar Oct 04 '21 16:10 skilly-lily

Thanks, @scruffystuffs, an option would be nice.

jrudolph avatar Oct 12 '21 11:10 jrudolph

Hi @jrudolph - fyi I'm transferring this issue to fossa-cli repository, as the spectrometer code is migrated to fossa-cli repo now, and all future dev work will occur in fossa-cli.

meghfossa avatar Nov 15 '21 22:11 meghfossa

Hi @jrudolph, I wanted to let you know that we will be working on this issue soon. Thank you for filing this issue!

ANE-236 in our internal tracker.

zlav avatar May 20 '22 23:05 zlav

Hi @zlav, any update on this issue? We also find this really useful to have different exit codes for No analysis targets found in directory vs failed to analyze, so that we can customize the CI workflow to send appropriate feedbacks. Thanks

helobinvn avatar Apr 14 '23 03:04 helobinvn