selfoss icon indicating copy to clipboard operation
selfoss copied to clipboard

Consider using Zend-Feed instead of SimplePie

Open rajjanorkar opened this issue 6 years ago • 2 comments

I can see this project is using simplepie which is good, but very hard to understand and slow as well and few other things like i can not use my own choice HTTP Client etc.

I had look into Zend Feed and clearly documented so easy to extent and i can use my choice HTTP client.

Not sure how much work and what are all reasons we dont move from simplepie to zend-feed? There must be some reasons this awesome project considered to use simplepie? (not just because of no. of stars simplepie got)

Thank you.

rajjanorkar avatar Nov 09 '17 23:11 rajjanorkar

Cannot say why SimplePie was chosen, I was not here at the time – though I never heard of Zend Feed until now so that might be a reason.

SimplePie might as well be slower but it is hard to say without any concrete measurements. As for the documentation, I find the one on SimplePie’s website sufficient. But I agree Zend’s look a little nicer. Ability to use different HTTP client would be nice but it does not seem to be as convenient as just using HTTPlug.

With this in mind, would the effort needed to switch to a different library be worth it? It might be interesting in future for adding Pubsubhubbub support but there are more pressing priorities at the moment.

jtojnar avatar Nov 10 '17 00:11 jtojnar

Well, i have not really done much research but based on my initial analysis:

  • Zend-Feed looks promising
  • Code is really modular and very easy to understand if i want to dig deeper
  • Very easy to write extension to add functionality which are not supported by zend-feed
  • Supports reader, writer and Pubsubhubbub
  • Supports cache (Conditional get)
  • Ability to use our own HTTP client
  • Support almost all RSS, ATOM and other feeds versions
  • Does not support json feed (neither simplepie yet)

Regarding switch i am not sure whether it worth it or not, may be someone put some light here.

rajjanorkar avatar Nov 10 '17 23:11 rajjanorkar