selfoss icon indicating copy to clipboard operation
selfoss copied to clipboard

Images not considered in article length

Open davidoskky opened this issue 4 years ago • 2 comments

Long articles are not split in three columns if the whole article won't fit the page due to the presence of large images. It seems to me that images are not taken into account when calculating if the content will fit the page, in fact I always get long text only articles in a single only display but sometimes it happens that when I have a short article with many images, this will be displayed in three columns even if it does not fit the page. Sometimes the last column will not be completely filled, even though the other two go beyond the dimension of the page. I am using firefox on ad 1920x1080 display to access selfoss. Here is a reference to reproduce the problem: https://euvsdisinfo.eu/rss Both problems can be observed in the two articles of 18/06. This problem is not consistent, as after opening the same article several times it will be displayed in a single column.

This is by no means an urgent problem, but I hope pointing this out will eventually be useful to find a solution.

davidoskky avatar Jun 20 '20 17:06 davidoskky

Thanks for reporting. This has been bugging me for a while and now https://github.com/SSilence/selfoss/pull/1204 should finally fix it.

We cannot do much about images that do not have height set but hopefully those will be rare.

jtojnar avatar Jun 21 '20 01:06 jtojnar

I have been running selfoss with the patch for a while and unfortunately, images without dimensions are majority of images I encountered :crying_cat_face:

I am thinking of having selfoss download all images without dimensions on the server side and add the appropriate attributes (of course, there would be an option to disable that feature).

jtojnar avatar Jul 12 '20 17:07 jtojnar