selfoss
selfoss copied to clipboard
fossar
The page titles for the 'hashpassword.html' and 'opml.html' are not getting inherited from the configs.
The titles of above said pages are not getting inheritid from the configurations. I've tried modifying somethings in 'selfoss-ui.js' but it didn't worked. For example: if ($('body').is('#hashpasswordbody, #opmlbody')) { // we do not want to create UI for non-app pages but we want to inherit the title of those pages from the configurations. $(document).attr('title', selfoss.htmlTitle); return; }
But it is not working. I've tried various more things but no luck as of now. @jtojnar Can you please look into this?
Yeah, we no longer include the whole selfoss script to those pages. I intend to integrate the OPML page into the selfoss settings page, which will fix it for that, and also allow us to translate it. For the password page, it should be only used by the person who installs selfoss, so they will know their instance is runnng selfoss and it should not be confusing.
In d39d5503, I have made the titles more descriptive, which is even more important.
ok, yes, making the page titles more descriptive and contextual is more important
On 10/4/19, Jan Tojnar [email protected] wrote:
Yeah, we no longer include the whole selfoss script to those pages. I intend to integrate the OPML page into the selfoss settings page, which will fix it for that, and also allow us to translate it. For the password page, it should be only used by the person who installs selfoss, so they will know their instance is runnng selfoss and it should not be confusing.
In d39d5503, I have made the titles more descriptive, which is even more important.
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/SSilence/selfoss/issues/1147#issuecomment-538352809
I was wondering that isn't there any way to retrieve the titles from the configurations as previous?
On 10/4/19, Akash Kakkar [email protected] wrote:
ok, yes, making the page titles more descriptive and contextual is more important
On 10/4/19, Jan Tojnar [email protected] wrote:
Yeah, we no longer include the whole selfoss script to those pages. I intend to integrate the OPML page into the selfoss settings page, which will fix it for that, and also allow us to translate it. For the password page, it should be only used by the person who installs selfoss, so they will know their instance is runnng selfoss and it should not be confusing.
In d39d5503, I have made the titles more descriptive, which is even more important.
-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/SSilence/selfoss/issues/1147#issuecomment-538352809