gas-webpack-plugin icon indicating copy to clipboard operation
gas-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon fossamagna

Switch to TypeScript

Open rhbvkleef opened this issue 4 years ago • 3 comments

rhbvkleef avatar May 26 '20 13:05 rhbvkleef

Coverage Status

Coverage decreased (-0.3%) to 94.444% when pulling 6eab940cd9d88243cca998b9d636ca3a7e7d3363 on rhbvkleef:master into d323a0bf8afee80a28bf72779bef4aa7634cce72 on fossamagna:master.

coveralls avatar May 26 '20 13:05 coveralls

How should I deal with the decreased coverage? The coverage did not effectively change. Only the if-statement checking compiler.hooks has one uncovered branch, just like in the upstream version.

rhbvkleef avatar May 26 '20 14:05 rhbvkleef

@rhbvkleef Thank you for your contribution. Could you to fix belowing to:

  • Follow to master branch. (fix conflict)
  • Use ESLint + ESLint TypeScript Plugin instead of TSLint, because of TSLint is deprecated.

And, I think that no required to deal with the decreased coverage.

fossamagna avatar Aug 15 '20 01:08 fossamagna