apidash icon indicating copy to clipboard operation
apidash copied to clipboard
verified publisher icon foss42

Added Proxy Configuration

Open abhinavs1920 opened this issue 11 months ago • 9 comments

PR Description

This pull request implements a feature that allows users to configure and use a proxy for their HTTP requests within the API Dash application. The feature includes a user interface for inputting proxy settings, storing these settings, and applying them to HTTP requests made using the http package in Flutter.

Related Issues

  • Closes #484

Checklist

  • [x] I have gone through the contributing guide
  • [x] I have updated my branch and synced it with project main branch before making this PR
  • [x] I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • [x] I have run the tests (flutter test) and all tests are passing

Added/updated tests?

  • [ ] Yes
  • [x] No, and this is why:

image

I have tested the proxy feature by running a squid proxy server in Python. Above I have attached the image proving that the proxy is working perfectly fine.

OS on which you have developed and tested the feature?

  • [x] Windows
  • [ ] macOS
  • [ ] Linux

abhinavs1920 avatar Jan 22 '25 08:01 abhinavs1920

Apart from the above comments, testing is also missing.

ashitaprasad avatar Jan 28 '25 16:01 ashitaprasad

@ashitaprasad I will make the required changes to make it cleaner, simpler, and optimized.

I have a question

  1. Should I create the ProxyModel in packages\apidash_core\lib\models?

abhinavs1920 avatar Jan 30 '25 07:01 abhinavs1920

@ashitaprasad I will make the required changes to make it cleaner, simpler, and optimized.

I have a question

  1. Should I create the ProxyModel in packages\apidash_core\lib\models?

Yes as it is being used by core service (sending http request)

ashitaprasad avatar Jan 30 '25 22:01 ashitaprasad

@ashitaprasad I have completed all the changes required. I have also added tests for the feature.

image

abhinavs1920 avatar Feb 03 '25 13:02 abhinavs1920

Hi @ashitaprasad, is there any update regarding this PR.

abhinavs1920 avatar Mar 08 '25 10:03 abhinavs1920

@abhinavs1920 It is under review.

ashitaprasad avatar Mar 09 '25 23:03 ashitaprasad

@ashitaprasad

Please review the changes I have made to address the issues you mentioned.

I accidentally force-pushed my commits, which resulted in overwriting your changes. To correct this, I reverted to your last commit and then reapplied my changes on top of it. Let me know if any further modifications are needed.

abhinavs1920 avatar Mar 24 '25 08:03 abhinavs1920

@ashitaprasad

Please review the changes I have made to address the issues you mentioned.

I accidentally force-pushed my commits, which resulted in overwriting your changes. To correct this, I reverted to your last commit and then reapplied my changes on top of it. Let me know if any further modifications are needed.

@ashitaprasad Any update? Thanks!

abhinavs1920 avatar Mar 31 '25 17:03 abhinavs1920

@ashitaprasad Please look at the implementation after the updates I did. Let me know if the approach is fine.

I'll update the branch and resolve the conflicts.

abhinavs1920 avatar Apr 10 '25 09:04 abhinavs1920