fpm icon indicating copy to clipboard operation
fpm copied to clipboard

Published 20 hours ago • verified publisher icon fortran-lang

Enable profiles in toml

Open kubajj opened this issue 3 years ago • 5 comments

Enable compiler profiles to be loaded into the package. Profiles are not used in any way yet. Tests in the test/fpm_test/test_manifest.f90 are making sure the functionality is behaving as expected. This is first part of #498 to be merged as it is difficult to merge such a big PR. This is still a huge PR as the file src/fpm/manifest/profiles.f90 is a completely new file with a lot of functionality in it.

kubajj avatar Jan 25 '22 23:01 kubajj

@kubajj and I are trying to take another run at the compiler profiles, submitting PRs in smaller increments. Could one or two people please perform a review of this one?

everythingfunctional avatar Feb 02 '22 21:02 everythingfunctional

Thanks @kubajj and @everythingfunctional - I'll put some time to review this this weekend.

LKedward avatar Feb 04 '22 08:02 LKedward

@LKedward about the changes to the manifest being included in the PR. I was thinking that since the profiles are not used yet, then we should not include it so that it does not confuse anybody.

kubajj avatar Feb 07 '22 14:02 kubajj

@LKedward about the changes to the manifest being included in the PR. I was thinking that since the profiles are not used yet, then we should not include it so that it does not confuse anybody.

Of course, good point!

LKedward avatar Feb 07 '22 14:02 LKedward

This looks like it could be merged, no?

milancurcic avatar May 07 '22 19:05 milancurcic

Was there a reason this didn't get merged, or was it just forgotten about? I managed to resolve the merge conflict without much issue. Any chance we can go ahead and merge it now?

everythingfunctional avatar Sep 08 '22 18:09 everythingfunctional