impacket icon indicating copy to clipboard operation
impacket copied to clipboard

publish a wheel

Open dimbleby opened this issue 2 months ago • 4 comments

I notice that this package publishes only source distributions, so that every user has to build the wheel themselves. Better for package owners to build and publish wheels once and for all.

I did not find a workflow in this repository for publishing or I would have submitted a pull request. If you are doing this manually a typical workflow would be something like

python -m pip install build twine
python -m build
twine upload dist/*

dimbleby avatar Oct 23 '25 20:10 dimbleby

It could be handled with more ease once the project will be PEP-621 compliant (see #2072). A simple poetry build command will do the thing!

n3rada avatar Nov 29 '25 13:11 n3rada

Nothing against #2072: but python -m build is not more difficult than poetry build. Publishing a wheel need not be blocked on that pull request.

dimbleby avatar Nov 29 '25 15:11 dimbleby

Of course. However, Wheels should be published on PyPI, not stored in GitHub releases or the repo itself. I think this is clearly not an issue tho'.

n3rada avatar Nov 29 '25 17:11 n3rada

However, Wheels should be published on PyPI ...

I can't tell what your point is.

It sounds as though you think you are saying something different from what I am saying: but the whole point of this issue is to ask for wheels to be published to pypi

dimbleby avatar Nov 29 '25 18:11 dimbleby