react-dropzone-uploader icon indicating copy to clipboard operation
react-dropzone-uploader copied to clipboard

Align with new stricter TypeScript error typing

Open jonathannen opened this issue 3 years ago • 2 comments

TypeScript now has the flag useUnknownInCatchVariables set to true by default.

https://www.typescriptlang.org/tsconfig#useUnknownInCatchVariables

This causes importing Dropzone types to fail in projects using the default (or explictly true). Fix is to revert to the current behavior by assuming any explicitly.

jonathannen avatar Sep 04 '21 03:09 jonathannen

Hi, I'd like to tackle this one. I'm a first-time contributor, so any feedback is very welcome ^^

The (quite short) task list would look like this:

  • [x] Locate and cut pulse buttons rules
  • [x] Paste the code into a new file called _pulse.less
  • [x] Import the file in _animated.less

jrosellr avatar Sep 23 '20 18:09 jrosellr

Looks good! @JoanRosell I'll assign you

shahednasser avatar Sep 23 '20 18:09 shahednasser

Ok, I have moved the code, should I run: npm run watch npm run prettier npm run compile

Since I haven't modified src/sbuttons.less I don't know if I should recompile the CSS.

jrosellr avatar Sep 23 '20 20:09 jrosellr

Just run npm run compile. We need to compile the code, but it's enough to just run compile command

shahednasser avatar Sep 23 '20 20:09 shahednasser

Thank you for the support @shahednasser!

jrosellr avatar Sep 24 '20 18:09 jrosellr