react icon indicating copy to clipboard operation
react copied to clipboard

Refactored Form.jsx and fixed warnings.

Open azizk opened this issue 3 years ago • 2 comments

Hi!

I went ahead and rewrote/refactored the Form component whilst paying attention to compiler warnings and other details. I also wanted to write tests but I didn't get that far yet. I did test it manually however.

Let's see if you like my changes and if you have suggestions to further improve the code. :+1:

azizk avatar Mar 26 '21 14:03 azizk

Wow! Thanks. I will have one of our React developers take a look at this next week and see if we can get a new build with these improvements. Thanks for your contributions!

travist avatar Mar 27 '21 17:03 travist

Unfortunately, this PR now needs to be rebased. We are planning another release of this library soon, so if you can get that in, we will be sure to include your changes.

travist avatar Dec 07 '21 21:12 travist

Hey unfortunately some of these changes conflict with some upcoming changes to the react library - additionally, I don't really love the idea of using some kind of bespoke propChanged method rather than React builtins - I'm going to close this for now but if we end up using anything from it you will definitely get credit!

brendanbond avatar Dec 28 '23 17:12 brendanbond