formio.js icon indicating copy to clipboard operation
formio.js copied to clipboard

FIO-7733: conditionally offload loader

Open brendanbond opened this issue 1 year ago • 0 comments

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7733

Description

In certain development circumstances, there was a javascript error in which the loader was no longer a child element of the main FJS element. This change merely checks that the loader is still a child before nullifying and removing the loader element.

Breaking Changes / Backwards Compatibility

Shouldn't be an issue, merely prevents a runtime error.

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • [x] I have completed the above PR template
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (if applicable)
  • [x] My changes generate no new warnings
  • [x] My changes include tests that prove my fix is effective (or that my feature works as intended)
  • [x] New and existing unit/integration tests pass locally with my changes
  • [x] Any dependent changes have corresponding PRs that are listed above

brendanbond avatar Feb 12 '24 20:02 brendanbond