formio.js icon indicating copy to clipboard operation
formio.js copied to clipboard

FIO-7733: export eventemitter

Open brendanbond opened this issue 1 year ago • 0 comments

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7733

Description

Our @formio/react library makes use of an EventEmitter class from eventemitter2 that exposes an onAny method. Newer versions of the @formio/js renderer extend a similar class from eventemitter3, so this PR just consolidates our usage of the EventEmitter to the one extended in @formio/js (in effect making it the "source of truth" EventEmitter), which should serve to make the overall interface a little bit cleaner and reduce the dependency load in @formio/react.

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • [x] I have completed the above PR template
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (if applicable)
  • [x] My changes generate no new warnings
  • [x] My changes include tests that prove my fix is effective (or that my feature works as intended)
  • [x] New and existing unit/integration tests pass locally with my changes
  • [x] Any dependent changes have corresponding PRs that are listed above

brendanbond avatar Feb 08 '24 17:02 brendanbond