formio.js icon indicating copy to clipboard operation
formio.js copied to clipboard

only generate key when it doesn't exist for custom group

Open claytongulick opened this issue 3 years ago • 1 comments

claytongulick avatar Jun 30 '22 19:06 claytongulick

This is to address the problem with the key field getting stomped on with custom components

claytongulick avatar Jun 30 '22 19:06 claytongulick

I like this change and am considering it, but this seems to only take into affect if you are using a group called "custom". What I would prefer is to make is so that this works if the component type is not found like so.

if (!Components.components.hasOwnProperty(info.type)) {

travist avatar Jul 26 '23 17:07 travist

Thanks @travist !

That PR was issued from when I was working for a company Telos Health Solutions, I'm not with them anymore and don't have access to the repo to modify the PR.

I recall this issue being a pretty big problem when we were mapping custom components to database columns, the ID getting stomped on forced us to fix it locally and operate off a fork.

Wonderful library, very powerful - keep up the amazing work!

claytongulick avatar Jul 26 '23 20:07 claytongulick

No worries... I can make the change myself if you agree with the change.

travist avatar Jul 27 '23 13:07 travist

I will make the change I suggested after I merge. Thank you for your contribution!

travist avatar Oct 04 '23 14:10 travist