angular icon indicating copy to clipboard operation
angular copied to clipboard

[Question] About the decision of use setFormFromSrc() only OnInit and not OnChange on Form lifecycle

Open Patcire opened this issue 8 months ago • 2 comments

Hello guys!

I was implementing some formio tasks at work last friday and we needed to change dinamically between differents Forms. When I changed @ Input() src the component was'nt re-render itself, so I needed to force it manually playing with value based condition and the method detectChanges().

The solution works but this behaviour looked strange to me so I've been reading the source code of "FormioBaseComponent"

lines 284 and 291

and saw that the method that control that "setFormFromSrc()" it's only used OnInit.

Powerful as it is render a Formio Form in our Angulars projects only with the src value, why is it not watched the changes to trigger a re-render? I imagine that there is a good reason, but I can't see it and I'm curious about it!

Thank you in advance :)

Patcire avatar Apr 12 '25 22:04 Patcire

Thank you for brining this to our attention. It should behave the way you are describing. We will create a ticket for this and put it in our backlog. https://formio.atlassian.net/browse/FIO-10120

ZenMasterJacob20011 avatar May 06 '25 20:05 ZenMasterJacob20011

We would also be able to review a PR if it is provided.

daneformio avatar May 12 '25 15:05 daneformio