formbricks icon indicating copy to clipboard operation
formbricks copied to clipboard

[BUG] Back Button is Autofocused with No Margin in Modal

Open JeevaRamanathan opened this issue 1 year ago • 3 comments

Issue Summary

When opening an embedded modal (or any modal), the back button in the top left is automatically focused, and it has no margin.

Steps to Reproduce

Attached the video

Expected behavior

he back button should not be focused by default when a modal is opened, and it should have appropriate margin for spacing.

Other information

(screen flickering happens due to the recorder when modal is opened)

https://github.com/user-attachments/assets/aec9cfd1-17cc-419e-9c1b-3e41439997ca

Screenshots

image

Environment

  • [ ] Formbricks Cloud (app.formbricks.com)
  • [ ] Self-hosted Formbricks

Desktop (please complete the following information)

- OS: Windows
- Browser: Chrome

JeevaRamanathan avatar Oct 31 '24 03:10 JeevaRamanathan

/award 50 thanks :)

jobenjada avatar Oct 31 '24 04:10 jobenjada

Awarding JeevaRamanathan: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/JeevaRamanathan

oss-gg[bot] avatar Oct 31 '24 04:10 oss-gg[bot]

@jobenjada can i work on this ?

Surajsuthar avatar Oct 31 '24 05:10 Surajsuthar

/assign

khAja13 avatar Nov 05 '24 04:11 khAja13

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

oss-gg[bot] avatar Nov 05 '24 04:11 oss-gg[bot]

This is fixed in the pull request #4226

khAja13 avatar Nov 07 '24 04:11 khAja13