formbricks icon indicating copy to clipboard operation
formbricks copied to clipboard

fix: adds CSP header

Open gupta-piyush19 opened this issue 1 year ago • 5 comments

What does this PR do?

Adds CSP header

Fixes https://github.com/formbricks/internal/issues/263

How should this be tested?

  • Everything should work fine
  • Test B

Checklist

Required

  • [ ] Filled out the "How to test" section in this PR
  • [ ] Read How we Code at Formbricks
  • [ ] Self-reviewed my own code
  • [ ] Commented on my code in hard-to-understand bits
  • [ ] Ran pnpm build
  • [ ] Checked for warnings, there are none
  • [ ] Removed all console.logs
  • [ ] Merged the latest changes from main onto my branch with git pull origin main
  • [ ] My changes don't cause any responsiveness issues
  • [ ] First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • [ ] If a UI change was made: Added a screen recording or screenshots to this PR
  • [ ] Updated the Formbricks Docs if changes were necessary

Summary by CodeRabbit

  • New Features

    • Introduced a new Content-Security-Policy header to enhance security by controlling resource loading.
    • Updated routing capabilities for more flexible API endpoint handling.
  • Bug Fixes

    • Removed a redundant duplicate entry for the /api/v1/me route in redirects.
  • Improvements

    • Enhanced configuration for handling headers, redirects, and rewrites for better application performance and security.

gupta-piyush19 avatar Oct 15 '24 09:10 gupta-piyush19

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 8:48am
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 8:48am

vercel[bot] avatar Oct 15 '24 09:10 vercel[bot]

Walkthrough

The changes in the next.config.mjs file enhance the configuration for headers, redirects, and rewrites within a Next.js application. A new Content-Security-Policy header is introduced to improve security by specifying resource loading directives. The redirects function has a duplicate entry for the /api/v1/me route, while the headers function now includes the new security header. The rewrites function remains unchanged, and the nextConfig object has been modified to include a conditional cache handler and allow all origins for images.

Changes

File Change Summary
apps/web/next.config.mjs - Added Content-Security-Policy header to global headers.
- Duplicate entry for /api/v1/me in redirects.
- Expanded headers to include new security header.
- Modified nextConfig for conditional cache handling and wildcard entry in remotePatterns.

Poem

🐇 In the land where code does play,
New headers guard the apps each day.
Redirects dance, rewrites sing,
Security blooms, oh what a thing!
With patterns wild, our paths align,
In this code garden, all will be fine! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 15 '24 09:10 coderabbitai[bot]

Thank you for following the naming conventions for pull request titles! 🙏

github-actions[bot] avatar Oct 15 '24 09:10 github-actions[bot]

/assign

THuNDeR-001 avatar Oct 15 '24 14:10 THuNDeR-001

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

oss-gg[bot] avatar Oct 15 '24 14:10 oss-gg[bot]