ledger icon indicating copy to clipboard operation
ledger copied to clipboard

feat: use sharedanalytics package

Open gfyrag opened this issue 3 years ago • 3 comments

feat: use sharedanalytics package

This basically extract the analytics code to go-libs library (https://github.com/numary/go-libs/pull/9). Please review go-libs before.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Refactoring / Technical debt

gfyrag avatar Aug 31 '22 14:08 gfyrag

Codecov Report

Merging #322 (62cbea4) into main (3563232) will increase coverage by 0.04%. The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   71.35%   71.40%   +0.04%     
==========================================
  Files          84       84              
  Lines        4632     4528     -104     
==========================================
- Hits         3305     3233      -72     
+ Misses       1023      998      -25     
+ Partials      304      297       -7     
Impacted Files Coverage Δ
cmd/internal/utils.go 100.00% <ø> (ø)
pkg/analytics/segment.go 38.63% <90.00%> (-18.63%) :arrow_down:
cmd/container.go 52.17% <100.00%> (+0.90%) :arrow_up:
cmd/root.go 87.20% <100.00%> (ø)
pkg/analytics/module.go 100.00% <100.00%> (ø)
pkg/ledger/ledger.go 68.93% <0.00%> (-0.83%) :arrow_down:
pkg/core/transaction.go 74.35% <0.00%> (+0.67%) :arrow_up:
pkg/storage/sqlstorage/driver.go 60.52% <0.00%> (+1.97%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 31 '22 14:08 codecov[bot]

@all-contributors please add @gfyrag for code

flemzord avatar Sep 22 '22 19:09 flemzord

@flemzord

I've put up a pull request to add @gfyrag! :tada:

allcontributors[bot] avatar Sep 22 '22 19:09 allcontributors[bot]