forksociety
Another way to check if pass the test
Sometimes I use py.test got failed, so I find out that I can use pip setup.py install, if install successfully and the outcome is the same as I imagine, then I can suggest that will pass the py.test.
What the hell is this? Have you really included an entire virtualenv in the pull request? Also the comments you've added are extremely misleading.
Oh, that's mean. I'm sorry about that, thank you for point out the mistake I have made, I will change it once I get home. But this PR is not a garbage. Have you make the changes, but when you use pytest, it shows 0 item collected in 0.01second? And that was happened last time I testing the project, since I was new to git, so I commit a lot of time, and I am sorry about that. But that's also the reason why I found out that using module install can also test if it's wrong with the changes I have made.
And thank you mention that I have to delete the virtualenv file, I think I would like to put that on contributing document, it allows newbie like me understand how to make a change in a right way.
I make the number of file correct and pull another request, I will close this PR, thanks for teaching again.
@LuckyPigeon Please run git status before committing. Also, take a pull from master branch before making changes. This can avoid merge conflicts.
@Depau Please be polite and welcoming to new contributors. I understand this might become frustrating but we believe in Open Code of Conduct or see CODE_OF_CONDUCT. This will result in pragmatic and productive conversations.
@PrabhanshuAttri When I saw the PR #67 , I have already push the update changes, is there any way to move this push to another branch?