forkcms
forkcms copied to clipboard
forkcms
Offline page
Type
- Feature
Pull request description
Adds service worker for offline page Internal reference https://app.activecollab.com/108877/reports/team-timeline?modal=Task-84793-62
Codecov Report
Merging #3376 (47f9430) into restructure-core (2b0b707) will increase coverage by
0.00%. The diff coverage is6.79%.
@@ Coverage Diff @@
## restructure-core #3376 +/- ##
===================================================
Coverage 32.93% 32.93%
- Complexity 8811 8822 +11
===================================================
Files 668 670 +2
Lines 32493 32587 +94
===================================================
+ Hits 10702 10733 +31
- Misses 21791 21854 +63
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| functional | 26.48% <6.79%> (+0.02%) |
8822.00 <7.00> (+11.00) |
|
| installer | 4.74% <0.00%> (-0.02%) |
8822.00 <7.00> (+11.00) |
:arrow_down: |
| unit | 12.17% <0.00%> (-0.04%) |
8822.00 <7.00> (+11.00) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| src/Backend/Modules/Pages/Actions/Settings.php | 0.00% <0.00%> (ø) |
7.00 <1.00> (+2.00) |
|
| ...nd/Modules/Pages/Domain/Page/Form/SettingsType.php | 0.00% <0.00%> (ø) |
3.00 <3.00> (?) |
|
| ...s/Pages/Domain/Page/SettingsDataTransferObject.php | 0.00% <0.00%> (ø) |
3.00 <3.00> (?) |
|
| src/Frontend/Core/Header/Header.php | 60.90% <70.00%> (+3.76%) |
62.00 <0.00> (+3.00) |
|
| src/Common/Core/Header/AssetCollection.php | 100.00% <0.00%> (+4.76%) |
8.00% <0.00%> (ø%) |
|
| src/Common/Core/Header/Minifier.php | 44.82% <0.00%> (+10.34%) |
7.00% <0.00%> (ø%) |
|
| src/Frontend/Core/Engine/Theme.php | 81.25% <0.00%> (+81.25%) |
7.00% <0.00%> (ø%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2b0b707...47f9430. Read the comment docs.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@bjorvack can you include a screenshot or something so we can see what it looks like?
