roaster icon indicating copy to clipboard operation
roaster copied to clipboard

Comments in the import section of a class stops Roaster.parseUnit()

Open bmarolleau opened this issue 1 year ago • 1 comments

Using Roaster 2.29. Adding a comment in the import part of a class with double slash prefix seems to stop parseUnit method, consequence: getInternal() is incomplete which results getting unit.getGoverningType() to return a org.jboss.forge.roaster.model.impl.JavaPackageInfoImpl class (unit.getClass()) instead of org.jboss.forge.roaster.model.source.JavaClassSource . Comments with /* */ format does not impact Roaster.parseUnit().

Example:

package com.mypackage 
import java.sql.Date; //this comment is problematic 
//this comment is problematic 
/*this one is not */
public class myClass { 
}

I suppose that Java standard allows comments in this section of the code. A workaround is of course to remove these comments.
But is it a normal behavior or known issue ? thanks for your help,

bmarolleau avatar Nov 10 '24 11:11 bmarolleau

Sounds like a parsing bug. Thanks for the reproducer

gastaldi avatar Nov 10 '24 11:11 gastaldi