plugin-arquillian icon indicating copy to clipboard operation
plugin-arquillian copied to clipboard

JUnit should be the default test framework

Open agoncal opened this issue 11 years ago • 15 comments

The command arquillian-setup should be optional, but if we use it, JUnit should be the default. At the moment, arquillian-setup asks you which test framework (TestNG or Junit). By default, it shouldn't ask, and use JUnit

[ArqEntity.java]$ arquillian-setup

[0] - testng
[1] - junit

***ERROR*** Test Framework must be specified.
***ERROR*** Test Framework Version must be specified.

agoncal avatar Jun 11 '14 09:06 agoncal

Why JUnit in particular?

bartoszmajsak avatar Jun 11 '14 09:06 bartoszmajsak

Because it's the one most commonly used : http://www.google.com/trends/explore#q=junit%2C%20testng&cmpt=q

agoncal avatar Jun 11 '14 09:06 agoncal

Well that's questionable ;) But I agree there should be the default for convenience. EDIT: Ok, new keywords are ambiguous :)

bartoszmajsak avatar Jun 11 '14 09:06 bartoszmajsak

Well, one or the other, really. A default would be great as more and more Forge commands have defaults (less typing) and it would be good if Arquillian also had more defaults

agoncal avatar Jun 11 '14 09:06 agoncal

Sure, I was trying to be a smartass today ;) I assume we are still talking about 1.x? If that's for 2.x I guess we will need to first bring the changes to this repository.

I will have a look at it this weekend.

Cheers!

bartoszmajsak avatar Jun 11 '14 09:06 bartoszmajsak

@bartoszmajsak yea, very questionable.. I always prefer cucumber salad over junit coding.. ;)

aslakknutsen avatar Jun 11 '14 09:06 aslakknutsen

All these issues are about 2.x

agoncal avatar Jun 11 '14 09:06 agoncal

@bartoszmajsak comments are based on this branch; https://github.com/aslakknutsen/plugin-arquillian/tree/forge2

I will push it to upstream master. Just gotta get the test suite fully functional again

aslakknutsen avatar Jun 11 '14 09:06 aslakknutsen

@aslakknutsen can you create a label for 2.x so that we can categorize issues?

bartoszmajsak avatar Jun 11 '14 09:06 bartoszmajsak

@bartoszmajsak it exists :)

aslakknutsen avatar Jun 11 '14 10:06 aslakknutsen

@bartoszmajsak 2.0 milestone

aslakknutsen avatar Jun 11 '14 10:06 aslakknutsen

Now in the correct thread: i agree that JUnit should be the default choice. Who uses TestNG nowadays? ;)

gastaldi avatar Jun 11 '14 10:06 gastaldi

As @bartoszmajsak pointed out, the list is actually a a lot longer then those two option. Those two are just the ones that are currently built in.

Maybe it would make sense to split them somehow.. (especially when we integrate all extensions in general)

Instead of 'setup arquillian', then user could give some pre hint to what h's trying to do, e.g.;

arquillian-test-bdd-functional-frontend <-- (named just to make the command complicated atm)

aslakknutsen avatar Jun 11 '14 10:06 aslakknutsen

Something like this ?

arquillian-create-test
arquillian-create-bdd-test
arquillian-create-selenium-test

agoncal avatar Jun 11 '14 11:06 agoncal

in theory they could just be aliases, but.. yea..

Some way to describe and provide a 'solution', not just dump single components on a user

aslakknutsen avatar Jun 11 '14 12:06 aslakknutsen