Martijn Gribnau

Results 180 issues of Martijn Gribnau

e.g. if we now run: `cargo msrv list` we will fetch the rust-releases index, while this is unnecessary for the `list` sub command: ``` Finished dev [unoptimized + debuginfo] target(s)...

C-enhancement
S-help-wanted
A-rust-releases

Instead of running a subcommand with: ```rust fn run(&self, config: &Config, reporter: &R) -> TResult; ``` we can do: ```rust fn run(&self, reporter: &R) -> TResult; ``` And let each...

This flag should: * Set or update the MSRV when found, and the crate has a [package] table (ie is not a virtual workspace) * Retain the TOML styling if...

https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html - [ ] Setting it when the msrv is found, and a flag is given (#328) - [x] #141 - [ ] Resolving from package set (new find msrv...

C-tracking

* What is important in an error * How can we help a user solve an error, caused by the user or the users platform * Can we report and...

S-help-wanted
C-refactor
C-discussion
A-user-output

Rough high level design overview: * https://excalidraw.com/#json=9VUt8xBhx1k9nUFaxyN1Y,mEZmrerjeiD6b9n2suIwUA **Sub-commands** ![cargo-msrv-subcommands](https://user-images.githubusercontent.com/5955761/147395053-2e5588c4-933c-4745-adbd-7a781ca403b9.png) **Actions** ![cargo-msrv-actions](https://user-images.githubusercontent.com/5955761/147395070-aa5644fe-68e5-4c25-ad85-76374dcd87fa.png)

C-program-architecture
S-help-wanted
S-considering
C-discussion
A-architecture

What?: Cache the Rust toolchains we use for testing Where?: Paths are `~/.rustup/toolchains/...` Why?: Improve build times by keeping toolchains installed, and thus not require network activity, plus toolchain installation...

C-enhancement
C-infrastructure
A-tooling

* ignores the `{rust-toolchain, rust-toolchain.toml, ...}` file by renaming it temporarily

C-enhancement
A-cli

Like `cargo_metadata` but for cargo-msrv :) Also an opportunity to rethink the json (structured) output format.

C-enhancement
A-user-output