salesforcedx-vscode icon indicating copy to clipboard operation
salesforcedx-vscode copied to clipboard

feat: change status bar color when in production org setting

Open PierreVanobbergen opened this issue 11 months ago • 4 comments

fix #5517

What does this PR do?

Create a setting to allow the status bar to change color when the default org is a production one

What issues does this PR fix or reference?

Check #5517 for details

PierreVanobbergen avatar Mar 22 '24 18:03 PierreVanobbergen

Thanks for the contribution! Before we can merge this, we need @PierreVanobbergen to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] avatar Mar 22 '24 18:03 salesforce-cla[bot]

Some notes about the feature/PR:

  • The code will change the User settings and not the Workspace setting, as it would modify the file under .vscode/settings.json that could be tracked in version control
  • The Japanese translation was made using DeepL, I'm not fluent at all, so if it's important, it needs to be checked.
  • I would like some feedback about the OrgAuthInfo.isAProductionOrgto see if it's the correct way to deduce if an org is a production one

Thank you :)

PierreVanobbergen avatar Mar 22 '24 18:03 PierreVanobbergen

Hi @PierreVanobbergen, thank you for this contribution! I just saw the video you shared in the issue, and the comment I have is that the color should apply to only the org picker (that element where the org alias is displayed), because we have other items in the bottom bar that have colors according to the state and we would miss that with how this is working now. Do you think you could limit the feature to just the org picker? Thanks!

CristiCanizales avatar Mar 22 '24 18:03 CristiCanizales

Hi @PierreVanobbergen, thank you for this contribution! I just saw the video you shared in the issue, and the comment I have is that the color should apply to only the org picker (that element where the org alias is displayed), because we have other items in the bottom bar that have colors according to the state and we would miss that with how this is working now. Do you think you could limit the feature to just the org picker? Thanks!

I thought about just changing the color of the org picker as well, but I feel that it might not be enough of an eye catcher 👀 . I would like to keep the status bar color change, but maybe having the setting to be where the change happens might be the way. Like this: image

We might even add more element later in the picklist.

What do you think about it @CristiCanizales ?

PierreVanobbergen avatar Mar 25 '24 08:03 PierreVanobbergen