lightning-language-server icon indicating copy to clipboard operation
lightning-language-server copied to clipboard

Linter should ignore `__tests__` folder when invoking `@lwc/metadata`

Open nolanlawson opened this issue 1 year ago • 3 comments

Summary

Users are reporting (https://github.com/salesforce/sfdx-lwc-jest/issues/350) that import { createElement } from 'lwc' is showing a red squiggly in VS Code even though this is not considered a lint error anywhere else in the system (e.g. when running eslint on the command line or publishing via SFDX).

Our team looked into this, and we believe the solution is the following:

  • The compiler ignores files that are in __tests__ folder and hence the linting rules do not apply. That explains why they are not facing any issues when saving the component.
  • The fix would be to make language server mimic the same and ignore tests folder when invoking @lwc/metadata.

Steps To Reproduce:

  1. Add import { createElement } from 'lwc' to a __tests__ (Jest) test in an SFDX project.

Expected result

No red squiggly should appear.

Actual result

A red squiggly appears.

Additional information

Please see https://github.com/salesforce/sfdx-lwc-jest/issues/350 for the original bug report.

VS Code Version: Unknown

SFDX CLI Version: Unknown

OS and version: Unknown

nolanlawson avatar Feb 22 '24 18:02 nolanlawson

As requested from the previous thread: VS Code Version: 1.86.2, x64 SFDX CLI Version: 2.29.5 OS and version: Windows 10 22H2 Build 19045.4046

BatemanVO avatar Feb 22 '24 18:02 BatemanVO

Same

  • VS Code Version: 1.85.1 (Universal) image
  • sf-cli version: @salesforce/cli/2.25.7 darwin-arm64 node-v18.19.0
  • OS: macOS Sonoma 14.2.1 (Apple M2 Max)

erocheleau avatar Feb 22 '24 20:02 erocheleau

I'm here to report the same issue.

  • VS Code Version: image
  • sf cli version: @salesforce/cli/2.9.8
  • OS: Windows 11 Pro x64

EmilynPantelakis avatar Mar 11 '24 18:03 EmilynPantelakis

@nolanlawson what's the solution for this, I'm facing the same issue.

Image

BaswarajTandur avatar Feb 07 '25 10:02 BaswarajTandur