SFDX-Data-Move-Utility icon indicating copy to clipboard operation
SFDX-Data-Move-Utility copied to clipboard

Sometimes needUpdate() returns a null/undefined

Open marqroldan opened this issue 4 years ago • 6 comments

I did a quick check on the code and it seems like it's correct that it's returning an object which is why I find it weird. It seems to happen whenever there's an interruption with the internet connection or general internet problem. Will dig further

marqroldan avatar May 26 '20 02:05 marqroldan

@marqroldan hi, you need add country to method options VersionCheck.needUpdate({ country: 'ru', })

I went through the code and found out that the country was based on a current locale (for iOS):

- (NSString*) country
{
    return [[NSLocale currentLocale] objectForKey:NSLocaleCountryCode] ?: @"";
}

And it return empty string for me)

legion-zver avatar May 27 '20 10:05 legion-zver

@kimxogus hi, please add default country options or change method get country for iOS)))

legion-zver avatar May 27 '20 10:05 legion-zver

Shouldn't the current locale / country be the one selected as accessing the app stores would be based on where they are? Or is it based on the nationality of the account?

Edit: I haven't had time to thoroughly check on the issue and instead just added a check if the resolved value is an object or not

marqroldan avatar May 27 '20 15:05 marqroldan

We experience the same issue

Hatko avatar Sep 29 '20 07:09 Hatko

  • I added default country config to my needUpdate function.
  • I installed the library with yarn add and i call pod install for auto-linking
  • Nothing is changed. Sometimes needUpdate() returns undefined object

Any update for this Issue?

bahtiyarerden avatar Jan 26 '21 20:01 bahtiyarerden

up

pietro-marrone-dka avatar Sep 27 '23 11:09 pietro-marrone-dka