DeepCloner icon indicating copy to clipboard operation
DeepCloner copied to clipboard

Cloner class

Open smolchanovsky opened this issue 6 years ago • 5 comments

This class will allow users not to write wrappers to make their code more testable and flexible.

smolchanovsky avatar Oct 20 '18 08:10 smolchanovsky

Looks good, but it would be really nice to get rid of the statics..

niemyjski avatar Oct 24 '18 13:10 niemyjski

Sorry for long delay. What is the sense of this PR? It looks like as copy of DeepClonerExtensions class but without static members (except ShallowClone but it seems as mistake in PR). If this class is helper for testing or for ability to replace implementation, all methods should be virtual (to override it in descendant class). Or some ICloner interface should be extracted.

force-net avatar Dec 17 '19 21:12 force-net

This class is really helper for testing and replacing implementations. But you are absolutely right, without an interface it makes no sense. For some reason, I forgot to add it, sorry.

smolchanovsky avatar Dec 22 '19 06:12 smolchanovsky

@force-net hi! 4 years have passed, I think it's time to merge pr, if everything is ok =)

smolchanovsky avatar Dec 17 '22 08:12 smolchanovsky

Sorry for delay. I'll try to find time to do this on new year's holidays.

force-net avatar Dec 19 '22 11:12 force-net