jesse icon indicating copy to clipboard operation
jesse copied to clipboard

Compilation warning with otp26.1.1

Open enirood-p opened this issue 2 years ago • 4 comments

For otp 26.1.1, compiler complains with the usage of 0.0 as otp 27 will evaluate +0.0 =:= -0.0 as false. However, +0.0 == -0.0 will continue to evaluate to true. Refer https://www.erlang.org/doc/general_info/upcoming_incompatibilities#0.0-and--0.0-will-no-longer-be-exactly-equal

enirood-p avatar Oct 11 '23 05:10 enirood-p

PR for fixing above: https://github.com/for-GET/jesse/pull/133

enirood-p avatar Oct 11 '23 05:10 enirood-p

For anyone in a Rebar project having this issue with Jesse as a dependency, a workaround is to add this to rebar.config:

{overrides, [
    {add, jesse, [{erl_opts, [nowarn_match_float_zero]}]}
]}.

eproxus avatar Nov 01 '23 14:11 eproxus

I thought this was already fixed in #129 ?

srijan avatar Nov 17 '23 08:11 srijan

Why not cut a new release ? https://github.com/for-GET/jesse/pull/128#issuecomment-1830795090

zmstone avatar Feb 14 '24 09:02 zmstone

Would it be possible to make a new release and publish on hex?

Taure avatar Jul 26 '24 07:07 Taure

Thank you everyone! I haven't been active in the Erlang world "recently" and snoozed notifications. Dusting off and looking into this...

PS: apologies for singling you out @zmstone but you are actively contributing Erlang on github.com. Would it be ok with you to become an outside contributor and keep an eye on jesse? 🤔

andreineculau avatar Jul 26 '24 10:07 andreineculau

Closing in favour of #130

andreineculau avatar Jul 26 '24 11:07 andreineculau

Thank you everyone! I haven't been active in the Erlang world "recently" and snoozed notifications. Dusting off and looking into this...

PS: apologies for singling you out @zmstone but you are actively contributing Erlang on github.com. Would it be ok with you to become an outside contributor and keep an eye on jesse? 🤔

Sure. Please add me.

zmstone avatar Jul 28 '24 18:07 zmstone

If you need more maintainer for this repo I am happy to help. We use it at company and also for some plugins for Nova framework.

Taure avatar Jul 28 '24 22:07 Taure