SierraDeathGenerator icon indicating copy to clipboard operation
SierraDeathGenerator copied to clipboard

Merge 5 years of community PRs + add URL parameter sharing

Open aaronsb opened this issue 2 months ago • 1 comments

Summary

This PR consolidates ~5 years of open community contributions and adds a new URL parameter feature for easy sharing.

Merged Community PRs (11 total)

Bug Fixes:

  • PR #45: Update .gitignore to ignore Thumbs.db
  • PR #46: Fix Pokemon R/B textbox text being one line too high
  • PR #27: Fix transparency on several Sierra icons
  • PR #71: Sort Yu-Gi-Oh! entries alphabetically

New Games (7):

  • PR #51: Dragon Warrior (Dragon Quest) for NES
  • PR #52: Lagoon
  • PR #60: Puyo Puyo Fever (GBA)
  • PR #61: MegaMan Battle Network 5
  • PR #63: Phantasy Star 3 Dialog
  • PR #69: Bio Force Ape
  • PR #78: Buffy the Vampire Slayer: Wrath of the Darkhul King

New Feature: URL Parameter Sharing

From the README:

Two commonly asked questions are "Does the death generator have an API?" and "Can I easily run it from the command line?" and the answer to both questions is no.

This PR adds a lightweight alternative for the sharing use case: URL query parameters.

Examples:

?text=Custom%20message#doom
?text=Hello&Portrait=Giles1&Background=Buffy#darkhul
?text=Message&wordwrap=off&transparent=on#bsod

Features:

  • ?text= parameter for custom text (supports newlines as %0A, formatting tags like [inverse])
  • Overlay parameters (dropdowns/sliders) by name (e.g., ?Portrait=Giles1)
  • Checkbox parameters (?wordwrap=off, ?transparent=on)
  • Auto-updating URL: As users edit text or change settings, the URL updates in real-time
  • Clean URLs: Only non-default values are included
  • Switching generators resets to default text (no carryover bug)

Users can now easily share specific generator configurations by copying the URL from their browser.

Test Plan

  • [x] Tested URL parameters across multiple generators (BSOD, Doom, Zelda, Pokemon, Space Quest, Dragon Warrior, Buffy)
  • [x] Verified formatting tags work ([inverse]...[/])
  • [x] Verified overlay parameters work
  • [x] Verified URL auto-updates on text/setting changes
  • [x] Verified dice roll resets to new generator's default text
  • [x] All merged PRs tested individually

aaronsb avatar Dec 11 '25 14:12 aaronsb

wow good work!

langel avatar Dec 11 '25 16:12 langel